packages [go_router_builder] Proposal: add json support, custom string encoder/decoder

Add initial json support for use in go_router_builder Adds annotation that enable custom string encoder/decoder, its enable conversion for base64

This allow custom type conversion for parameters, like mentionated in #117261 and #110781

Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
[x] I linked to at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Feb 20 '25 02:02 NearTox

you also need to bump versions in packages/go_router_builder/CHANGELOG.md and packages/go_router_builder/pubspec.yaml

Feb 24 '25 23:02 hannah-hyj

thank you for contributing the PR! This looks good to me over all with some comments

Feb 24 '25 23:02 hannah-hyj

PR looks good to me over all, just left some nit comments :)

Mar 17 '25 22:03 hannah-hyj

I made a rebase in order to take in account latest changes from main branch

Mar 19 '25 16:03 NearTox

looks like the ci is not happy

Mar 21 '25 20:03 chunhtai

I think it’s because the annotations requires the changes that I made in go_router_builder. When I tested locally was overriding the dependency. I should add it?

Mar 21 '25 22:03 NearTox

they will have to be separate into two prs. I think we try to avoid having one pr that bump the two package at once

Mar 21 '25 22:03 chunhtai

Hi @NearTox , is this PR still on your radar? this pr has to be separated into 2 PRs for go_router and go_router_builder

May 02 '25 22:05 hannah-hyj

Hi @hannah-hyj , sorry for the delayed reply. I splitted into two PR (chained commits) I made a rebase in order to reach the last version of the go_router_builder

Jun 07 '25 00:06 NearTox

Thanks for the updates, and for contributing @NearTox! It looks like this is currently failing a lot of tests, can you take a look?

Jun 18 '25 19:06 Piinks

@NearTox Take a look at the failures and conflicts here when you get a chance.

Jul 21 '25 18:07 justinmc

@justinmc in order to fix build issue the PR #9404 is required to be merged or meanwhile I can use
path: .../go_router in the pubspec.yaml to pass the build

Jul 23 '25 17:07 NearTox

Hi @NearTox,

The PR https://github.com/flutter/packages/pull/9404 has been merged — thank you for your support in getting this one finished as well!

Aug 04 '25 21:08 muhammadkamel

@NearTox Any updates?

Aug 16 '25 18:08 muhammadkamel

Hi @chunhtai I will to rebase the PR in order to resolve conflict

Aug 18 '25 20:08 NearTox

@chunhtai I need to resolve again the conflicts?, I mean with the same version or distinct?

Aug 19 '25 17:08 NearTox

you should bump the version above the current. yeah this kinda of merge conflict is a bit annoying. I have been working on a design doc to address this

https://docs.google.com/document/d/18kjoP-4LAXEllugVOQRg6vZELyD6MuxlKilLD4lFxSY/edit?tab=t.0

Aug 19 '25 17:08 chunhtai

@chunhtai done

Aug 19 '25 18:08 NearTox

@chunhtai the changelog for go_router is only for fix the notice, I don't intent to make a new release. If you think that the update in the notice (for a old release) not matters. I can remove it

Aug 19 '25 19:08 NearTox

@chunhtai

Could you please assign another reviewer? Hannah might be on vacation, and this feature is important for us.

Aug 22 '25 20:08 muhammadkamel

Hi @chunhtai, I hope we can merge this PR as soon as possible.

Aug 28 '25 17:08 muhammadkamel

@NearTox Could you please resolve the conflicts so we can proceed with merging this PR?

Sep 02 '25 07:09 muhammadkamel

autosubmit label was removed for flutter/packages/8665, because The base commit of the PR is older than 7 days and can not be merged. Please merge the latest changes from the main into this branch and resubmit the PR.

Sep 16 '25 22:09 auto-submit[bot]