packages icon indicating copy to clipboard operation
packages copied to clipboard

[video_player] Direct control over rotation of videos

Open AndreSbro03 opened this issue 1 year ago • 3 comments

If the argument rotation is passed the player ignore the controller.value.rotationCorrection and rotates the video by an angle (in degrees) specified in the variable. This allows more control over the video on the part of the user.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

AndreSbro03 avatar Oct 09 '24 10:10 AndreSbro03

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

flutter-dashboard[bot] avatar Oct 09 '24 10:10 flutter-dashboard[bot]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 09 '24 10:10 google-cla[bot]

Thanks for the submission!

In the future, please do not delete the checklist that is in the PR template; it is there for a reason. This PR is missing required elements described in the checklist (I’ve restored it to the PR description), which need to be addressed before it moves forward with review.

I am marking the PR as a Draft. Please review the checklist, updating the PR as appropriate, and when that’s complete please feel free to mark the PR as ready for review.

In the issue you file, please provide use case details explaining why this needs to be built into the plugin rather than clients wanting arbitrary rotation just wrapping the widget in their own transform.

stuartmorgan-g avatar Oct 09 '24 11:10 stuartmorgan-g

Since this is marked as a draft and hasn't been updated in several months, I’m going to close it so that our PR queue reflects active PRs. Please don't hesitate to submit a new PR if you decide to revisit this. Thanks!

stuartmorgan-g avatar Dec 03 '24 20:12 stuartmorgan-g