packages icon indicating copy to clipboard operation
packages copied to clipboard

[WIP] Applied Gradle Plugins Declaratively for `path_provider`

Open jesswrd opened this issue 1 year ago • 3 comments

Updated applying gradle plugins from usage of imperative apply to usage of declarative blocks {} apply. Intending on updating all android example apps under packages. Did one more as a proof of concept before doing more.

More information on Flutter Gradle Plugin Apply here

Partially addresses #152656

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jesswrd avatar Oct 08 '24 17:10 jesswrd

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

flutter-dashboard[bot] avatar Oct 08 '24 17:10 flutter-dashboard[bot]

Looks like this change triggers a new check on the existing targetSdkVersion value?

stuartmorgan-g avatar Oct 08 '24 20:10 stuartmorgan-g

Looks like this change triggers a new check on the existing targetSdkVersion value?

Yeah, I think the current targetSdkVersion is outdated. I'm just going to update it to 35 (most recent one)

jesswrd avatar Oct 08 '24 21:10 jesswrd