flutter
Remove use_modular_headers! from Podfiles
⚠️ This PR only changes unpublished parts of example apps and tests. I have added the override: no versioning needed label.
We added use_modular_headers! to our Podfiles as we originally planned to phase out use_frameworks! (see https://github.com/flutter/flutter/pull/42204). However, our plans have now changed and we are instead phasing out CocoaPods entirely in favor of Swift Package Manager.
CocoaPods's use_frameworks! and use_modular_headers! are two different overlapping options that should not be used together. This change removes the use_modular_headers! from example apps' Podfiles. This change does not affect packages themselves.
Part of https://github.com/flutter/flutter/issues/156259
Pre-launch Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I read the Tree Hygiene page, which explains my responsibilities.
- [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use
dart format.) - [x] I signed the CLA.
- [ ] The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences] - [x] I linked to at least one issue that this PR fixes in the description above.
- [x] I updated
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes. - [x] I updated
CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes. - [x] I updated/added relevant documentation (doc comments with
///). - [x] I added new tests to check the change I am making, or this PR is test-exempt.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
⚠️ This PR only changes unpublished parts of example apps and tests. I have added the
override: no versioning neededlabel.
Could you link to the failing run that led to adding this label? CI should not have flagged this as needing a version change.
@stuartmorgan Ah, I misunderstood the content at the bottom of this section to mean "Add the override label once you've verified your change meets these conditions": https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#version
I'll update this README to clarify this label should only be added if the CI check fails: https://github.com/flutter/flutter/pull/156342
This is now ready for review! The webview test failure that affected this change was also fixed by https://github.com/flutter/flutter/issues/157449