packages icon indicating copy to clipboard operation
packages copied to clipboard

[camera] Convert Windows to Pigeon

Open stuartmorgan-g opened this issue 1 year ago • 1 comments

Replaces all of the manual method channel code in camera_windows with Pigeon.

I attempted to change the structure as little as possible, since this was already a large change. I don't particularly like the way the native result callback objects are managed (passed to Camera and tracked in a map), but I decided that redesigning that would be out of scope and introduced a std::variant to allow minimal changes to that structure. That does slightly undermine the type safety of the callbacks, but it's still strictly enforced at the level of the helpers that interact with the map.

Fixes https://github.com/flutter/flutter/issues/117905

Pre-launch Checklist

stuartmorgan-g avatar Jun 14 '24 14:06 stuartmorgan-g

@cbracken Ping on this review in case you missed the notification while you were out.

stuartmorgan-g avatar Jun 27 '24 16:06 stuartmorgan-g

Back as of yesterday and mostly caught up on mail. Looking!

cbracken avatar Jul 09 '24 16:07 cbracken