[pigeon] Kotlin implementation for ProxyApis
Kotlin portion of https://github.com/flutter/flutter/issues/134777
Pre-launch Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
- [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use
dart format.) - [x] I signed the CLA.
- [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences] - [x] I linked to at least one issue that this PR fixes in the description above.
- [x] I updated
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes. - [x] I updated
CHANGELOG.mdto add a description of the change, following repository CHANGELOG style. - [x] I updated/added relevant documentation (doc comments with
///). - [x] I added new tests to check the change I am making, or this PR is test-exempt.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
Are you planning to add the full implementation and test suite to this pr?
Are you planning to add the full implementation and test suite to this pr?
I wasn't planning on doing that for this PR, but I can if you prefer the full implementation. This PR just adds the Kotlin ProxyApi utility classes, including the InstanceManager and the tests for it. And also the bare minimum ProxyApi class declaration.
@tarrinneal I updated the PR to have the full implementation and tests. Its ready for a review.
From android triage: Reid is out for the rest of this week, does this need another Android reviewer in the meantime, or is work still ongoing?
@bparrishMines I think there needs to be some plumbing added to have the kotlin files generate using the tool/generate script
@tarrinneal What do you mean? I have been using dart run tool/generate.dart to generate the Kotlin code successfully. Is this the script you are referring to?
@tarrinneal What do you mean? I have been using
dart run tool/generate.dartto generate the Kotlin code successfully. Is this the script you are referring to?
yep, If it's working then don't worry about it :)