packages icon indicating copy to clipboard operation
packages copied to clipboard

[pigeon] Kotlin implementation for ProxyApis

Open bparrishMines opened this issue 1 year ago • 3 comments

Kotlin portion of https://github.com/flutter/flutter/issues/134777

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

bparrishMines avatar Mar 21 '24 19:03 bparrishMines

Are you planning to add the full implementation and test suite to this pr?

tarrinneal avatar Apr 10 '24 20:04 tarrinneal

Are you planning to add the full implementation and test suite to this pr?

I wasn't planning on doing that for this PR, but I can if you prefer the full implementation. This PR just adds the Kotlin ProxyApi utility classes, including the InstanceManager and the tests for it. And also the bare minimum ProxyApi class declaration.

bparrishMines avatar Apr 11 '24 16:04 bparrishMines

@tarrinneal I updated the PR to have the full implementation and tests. Its ready for a review.

bparrishMines avatar Apr 17 '24 19:04 bparrishMines

From android triage: Reid is out for the rest of this week, does this need another Android reviewer in the meantime, or is work still ongoing?

gmackall avatar Aug 22 '24 18:08 gmackall

@bparrishMines I think there needs to be some plumbing added to have the kotlin files generate using the tool/generate script

tarrinneal avatar Aug 27 '24 17:08 tarrinneal

@tarrinneal What do you mean? I have been using dart run tool/generate.dart to generate the Kotlin code successfully. Is this the script you are referring to?

bparrishMines avatar Aug 27 '24 18:08 bparrishMines

@tarrinneal What do you mean? I have been using dart run tool/generate.dart to generate the Kotlin code successfully. Is this the script you are referring to?

yep, If it's working then don't worry about it :)

tarrinneal avatar Aug 27 '24 19:08 tarrinneal