packages icon indicating copy to clipboard operation
packages copied to clipboard

[go_router_builder] add support to go_router_builder for initializing a StatefulShellBranch with observers

Open satoyan opened this issue 1 year ago • 5 comments

This pr added the ability to provide a list of NavigatorObservers to a StatefulShellBranch. The equivalent was never added to go_router_builder, so this pr provides that functionality.

With this change, you can provide NavigatorObservers directly to the StatefulShellBranch and fix https://github.com/flutter/flutter/issues/143869.

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • [x] I signed the CLA.
  • [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • [x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is test-exempt.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

satoyan avatar Jan 11 '24 03:01 satoyan

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jan 11 '24 03:01 google-cla[bot]

or anyone else create PR instead of me, please! :pray:

satoyan avatar Jan 11 '24 03:01 satoyan

Hi @satoyan , thank you for your contribution, can you also add tests to this pr?

hannah-hyj avatar Jan 12 '24 21:01 hannah-hyj

Thank you for your replying! I added some test cases and update version to pass CI. Please tell me anything else I need to do :bow: thank you. @hangyujin

satoyan avatar Jan 13 '24 10:01 satoyan

@johnpryan Hi John, can you take a second look at this since chun-heng is on vacation ?

hannah-hyj avatar Feb 02 '24 22:02 hannah-hyj

looks like there is a conflict and ci failing, can you fix them?

chunhtai avatar Apr 08 '24 19:04 chunhtai