Camera with MediaSettings: platform implementations (federated)

[PROGrand]

trafficstars

Platform implementations of federated plugin

This is the platform implementations part of camera PR #3586.

camera_platform_interface: 2.6.0 merged and published in PR #3615.

Now repeating steps 3,4 (see Changing federated plugins), because camera/camera depends on implementations camera/camera_android, camera/camera_web etc.

[PROGrand]

@stuartmorgan @ditman @camsim99 @bparrishMines Please review that. I have created a new PR that has only the platform implementation packages changes from the PR #3586, because there is interdependency between camera package and platform implementation packages like camera_android, camera_web etc. (repeating steps 3,4 of Changing federated plugins)

@hellohuanlin reviewed ios part (https://github.com/flutter/packages/pull/5223#pullrequestreview-1695786391)

[stuartmorgan-g]

@hellohuanlin This should be ready for iOS review.

[PROGrand]

@bparrishMines

@PROGrand This platform implementations contain different code than what is in #3586. Or at the very least, camera_android does? Is this intentioinal?

Sure intentionally. I followed @stuartmorgan review guidelines. Comparing to #3586: added tests, parameters enclosed in data-like class, also this PR updated from flutter:main, no-media-settings fix moved to standalone PR.

I planned to update #3586 on final review. Should I?

[bparrishMines]

@bparrishMines

@PROGrand This platform implementations contain different code than what is in #3586. Or at the very least, camera_android does? Is this intentioinal?

Sure intentionally. I followed @stuartmorgan review guidelines. Comparing to #3586: added tests, parameters enclosed in data-like class, also this PR updated from flutter:main, no-media-settings fix moved to standalone PR.

I planned to update #3586 on final review. Should I?

Yea, that's fine. I hadn't realized there were changes made from comments in this PR

[PROGrand]

@ditman Can you please review web test changes, you requested some time ago?

[PROGrand]

@ditman I implemented your suggestions for:

https://github.com/flutter/packages/pull/5223#pullrequestreview-1696228052 https://github.com/flutter/packages/pull/5223#discussion_r1375060277

Can you review changes for web implementations?

[ebjorklund01]

@camsim99 @bparrishMines Can anybody contact @ditman through a separate channel to complete this review? It looks like @PROGrand has addressed the concerns brought up through review.

[stuartmorgan-g]

@PROGrand FYI I've discussed with @ditman and he should be able to re-review this soon.

[PROGrand]

@stuartmorgan Hello, i applied all suggestions. Including your ones for camera_windows. @ditman approved camera_web.

[jmagman]

@stuartmorgan any more changes requested here? Or is this ready to be merged?

[jmagman]

@stuartmorgan this is blocked on your review

[PROGrand]

@stuartmorgan Thank, you for review. Your suggestions are applied.

[vashworth]

@stuartmorgan Can you take a look when you have time?

[PROGrand]

@stuartmorgan suggestions applied

[PROGrand]

@stuartmorgan resolved