packages icon indicating copy to clipboard operation
packages copied to clipboard

[web_view]Expose the allowsLinkPreview property in WKWebView for iOS

Open camfrandsen opened this issue 2 years ago • 14 comments

Based off of https://github.com/flutter/plugins/pull/5110 So most of the credit goes to @b099l3 Also exposed it through the webview_controller

This PR fixes this issue:

  • https://github.com/flutter/flutter/issues/69748
  • (duplicate) https://github.com/flutter/flutter/issues/100783

Pre-launch Checklist

  • [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • [x] I signed the [CLA].
  • [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].
  • [x] I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style].
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is [test-exempt].
  • [x] All existing and new tests are passing.

camfrandsen avatar Sep 28 '23 17:09 camfrandsen

@cyanglaz @bparrishMines I saw that you reviewed https://github.com/flutter/plugins/pull/5110 the first time. Sorry to make you re-review it... but I would love if you could review this. I did my best to port it over from that pr. Thank you for your help with this! Note, I checked the Linux and Mac checks, and saw that they had failed on previous pulls that went in, so I am assuming they failing on the main branch? Let me know though if there is something I need to do @b099l3 I figured you would want to be aware that I have ported your patch over to the new repo

camfrandsen avatar Sep 28 '23 17:09 camfrandsen

cc @bparrishMines

MitchellGoodwin avatar Oct 23 '23 19:10 MitchellGoodwin

@camfrandsen No worries, I'm glad it was of some use.

I had a guilt in the back of my mind to come back to it at some point and get it merged. So I can sleep easily now. 😅

b099l3 avatar Oct 24 '23 20:10 b099l3

@camfrandsen Please see https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins for how to structure this PR so that it will pass tests. Please let us know if you have any issues setting that up!

stuartmorgan-g avatar Oct 31 '23 19:10 stuartmorgan-g

I am splitting this into two pulls since I touched the webview_flutter_platform_interface: https://github.com/flutter/packages/pull/5292 https://github.com/flutter/packages/pull/5293

camfrandsen avatar Nov 01 '23 20:11 camfrandsen

I am splitting this into two pulls since I touched the webview_flutter_platform_interface

That's step 3 of the process, which should only be done after the previous steps (which include approvals of the combined PR) are complete.

stuartmorgan-g avatar Nov 01 '23 21:11 stuartmorgan-g

@stuartmorgan Ah, sorry about that. I looked at the failures of the checks, and it said that it needed to be broken up... I will re-open this one and close the other two.

camfrandsen avatar Nov 01 '23 21:11 camfrandsen

Update from triage: still waiting on the wrapper generator, which is currently under very active development.

stuartmorgan-g avatar Jan 09 '24 20:01 stuartmorgan-g

Sounds like this is blocked by other work. I am converting this to draft. feel free to request my review when it's ready.

hellohuanlin avatar Feb 12 '24 23:02 hellohuanlin

Any updates on this?

ftntming avatar Apr 11 '24 21:04 ftntming

Update from triage: the conversion to the new wrapper automation that this is blocked on is likely to be done sometime around August.

stuartmorgan-g avatar Jun 04 '24 19:06 stuartmorgan-g

Update from triage: still likely on track for August.

stuartmorgan-g avatar Jul 23 '24 19:07 stuartmorgan-g

(PR Triage): Hey @stuartmorgan is this still planned to move forward? Is it blocked on something?

Piinks avatar Sep 24 '24 23:09 Piinks

https://github.com/flutter/packages/pull/6602 is the blocking issue; it's just slipped slightly.

stuartmorgan-g avatar Sep 25 '24 18:09 stuartmorgan-g

From triage: This should be unblocked soon; https://github.com/flutter/packages/pull/7794 updates Android, and a similar PR for iOS will follow shortly.

stuartmorgan-g avatar Oct 29 '24 19:10 stuartmorgan-g

Sorry for the longer-than-expected delay here. https://github.com/flutter/packages/pull/8311 will unblock this, and is going through final review now.

stuartmorgan-g avatar Jan 16 '25 15:01 stuartmorgan-g

From triage: @camfrandsen Sorry for the long delay on the blocking PR. Are you still planning on updating this for the new API?

stuartmorgan-g avatar Mar 18 '25 19:03 stuartmorgan-g

I went ahead and updated the code to the new ProxyApi wrapper. There doesn't seem to be a comparable feature on Android to control preview links.

bparrishMines avatar Mar 31 '25 20:03 bparrishMines

Sounds like this should be ready for review then.

stuartmorgan-g avatar Apr 01 '25 14:04 stuartmorgan-g