packages icon indicating copy to clipboard operation
packages copied to clipboard

[go_router] Sets correct reverseTransitionDuration on NoTransitionPage (#123368)

Open josh-burton opened this issue 2 years ago • 0 comments

Sets the reverseTransitionDuration of NoTransitionPage to 1 microsecond to match the transition duration (and to ensure there is an instant reverse transition).

fixes https://github.com/flutter/flutter/issues/123368

List which issues are fixed by this PR. You must list at least one issue.

  • https://github.com/flutter/flutter/issues/123368

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • [x] I signed the CLA.
  • [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • [x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is test-exempt.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

josh-burton avatar Mar 24 '23 02:03 josh-burton