packages
packages copied to clipboard
[image_picker] bump androidx.activity:activity to 1.7.0
bumps androidx.activity:activity to 1.7.0
Pre-launch Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
- [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use
dart format
.) - [x] I signed the CLA.
- [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences]
- [x] I listed at least one issue that this PR fixes in the description above.
- [x] I updated
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes. - [x] I updated
CHANGELOG.md
to add a description of the change, following repository CHANGELOG style. - [x] I updated/added relevant documentation (doc comments with
///
). - [x] I added new tests to check the change I am making, or this PR is test-exempt.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).
If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?
Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.
@gmackall any chance you can help me with the failing tests? I'm not entirely sure what the conflict is. I'm sure it's simple enough though.
Oh interesting, this seems to be the same failure as the one on this dependabot pr https://github.com/flutter/packages/pull/3381. I put an initial guess as to the cause in the comments, but I'm actually not sure yet.
I've made an issue to track this failure https://github.com/flutter/flutter/issues/125062 and have a pr to fix it in one of the existing dependabot upgrades. I'm waiting for that to be approved/merged to confirm it works as expected, and then I will take over this one as well.
Note from triage @gmackall is taking this over.
Closing this as its a version with a solution to the duplicate class failures is here: https://github.com/flutter/packages/pull/3968