packages
packages copied to clipboard
[flutter_adaptive_scaffold] Add `transitionDuration` parameter.
Adds transitionDuration
parameter for specifying how long the animation should be.
This adds the following suggestion from the issue https://github.com/flutter/flutter/issues/114272
The duration of the animations are set to 1 second, we should have the option to set animation durations when creating slot layouts.
Originally posted by @jamiewest in https://github.com/flutter/flutter/issues/114272#issuecomment-1304288452
Pre-launch Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
- [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use
dart format
.) - [x] I signed the CLA.
- [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences]
- [x] I listed at least one issue that this PR fixes in the description above.
- [x] I updated
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes. - [x] I updated
CHANGELOG.md
to add a description of the change, following repository CHANGELOG style. - [x] I updated/added relevant documentation (doc comments with
///
). - [ ] I added new tests to check the change I am making, or this PR is test-exempt.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).
If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?
Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.
Thanks for the PR! This is a good feature to add, but there will have to be a test for the feature before we can accept it.
@gspencergoog I have added test. Can you review the conflicting changelog and test?
fixed versioning issue
Are you still planning on updating this PR to address the review comments above?
Yes. I am planning to update it. I will update it as soon as possible.
2023년 4월 19일 (수) 오전 4:50, stuartmorgan @.***>님이 작성:
Are you still planning on updating this PR to address the review comments above?
— Reply to this email directly, view it on GitHub https://github.com/flutter/packages/pull/3487#issuecomment-1513712610, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOALRCJKIM65LYCFCAPN4QTXB3V5ZANCNFSM6AAAAAAV77KZAA . You are receiving this because you authored the thread.Message ID: @.***>
Since this is still failing a lot of CI, I'm going to mark it as a draft; once it's passing tests please feel free to mark it as ready for review!
Since this is marked as a draft and hasn't been updated in several months I'm going to close it to clean out our review queue. Please don't hesitate to submit a new PR if you decide to revisit this. Thanks!
This is not a big change for the package, but is a big change for us developers. Please release this update!
Please release this update!
This PR was never completed, so there is nothing to release. Anyone in the community interested in this feature is welcome to make a new PR to implement it.