packages
packages copied to clipboard
Update tests to ignore `deprecated_member_use` where `TestWindow` API is used
Update tests to ignore deprecated_member_use where TestWindow API is used.
With #122824, the TestWindow API is deprecated. We need to ignore analysis errors from using deprecated members for CI to work, but don't want to update the API until 3.9.0 is in stable.
#122912 tracks the eventual migration to the new TestFlutterView API.
Progress towards #121915.
Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [x] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use
dart format.) - [x] I signed the [CLA].
- [ ] The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences] - [x] I listed at least one issue that this PR fixes in the description above.
- [x] I updated
pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes]. - [ ] I updated
CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style]. - [x] I updated/added relevant documentation (doc comments with
///). - [x] I added new tests to check the change I am making, or this PR is [test-exempt].
- [ ] All existing and new tests are passing.
Please don't set whole-file ignores
Should we add that to the analyzer script? Or would this maybe be a good lint?
If there were a way to configure the analyzer in analysis_options.yaml to only allow specific ignores to be file-level that would be something we could enable; I don't think it's enough of an issue to write our own file parser to do it manually absent that though.