packages
packages copied to clipboard
[go_router] Add navigator key to typed routes
This PR is the first step described in https://github.com/flutter/packages/pull/3439#discussion_r1136458688.
Pre-launch Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
- [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use
dart format
.) - [x] I signed the CLA.
- [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences]
- [ ] I listed at least one issue that this PR fixes in the description above.
- [x] I updated
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes. - [x] I updated
CHANGELOG.md
to add a description of the change, following repository CHANGELOG style. - [x] I updated/added relevant documentation (doc comments with
///
). - [ ] I added new tests to check the change I am making, or this PR is test-exempt.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).
If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?
Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.
@chunhtai
- Should I create a new issue just to say that we need these navigator keys?
- For the tests, it seems trivial to add a test just to make sure we can create an instance of
TypedShellRoute
andTypedGoRoute
by passing a navigator key. Shall I still do it?
This class is for annotation in go_router_builder, so I don't think it is testable in go_router package. The real test will be in go_router_builder when it starts to leverage the newly added parameters
test-exempt: code will be tested when applicable logic is added
auto label is removed for flutter/packages, pr: 3471, due to - This commit is not mergeable and has conflicts. Please rebase your PR and fix all the conflicts.