packages icon indicating copy to clipboard operation
packages copied to clipboard

Published 20 hours ago • verified publisher icon flutter

Return value when pop

Open NazarenoCavazzon opened this issue 1 year ago • 9 comments

In this PR I'm modifying the push and pushNamed by making them return a Future<T?>, and using completers to make the users able to return an wait values from within pages.

Fixes https://github.com/flutter/flutter/issues/99663. Fixes https://github.com/flutter/flutter/issues/107217 Fixes https://github.com/flutter/flutter/issues/100969

This PR will not conflict with older versions of go_router when updated.

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • [x] I signed the CLA.
  • [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • [x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is test-exempt.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

NazarenoCavazzon avatar Mar 03 '23 18:03 NazarenoCavazzon

@chunhtai Here it is

NazarenoCavazzon avatar Mar 03 '23 18:03 NazarenoCavazzon

Since this is not really a breaking change, so you don't need to write a breaking change doc. Consider moving the snippet in the doc into the example folder

chunhtai avatar Mar 03 '23 19:03 chunhtai

let me know if there's another change to make

NazarenoCavazzon avatar Mar 03 '23 19:03 NazarenoCavazzon

and the analyzer is not happy

chunhtai avatar Mar 03 '23 23:03 chunhtai

@chunhtai fixed the change log, almost forgot.

NazarenoCavazzon avatar Mar 03 '23 23:03 NazarenoCavazzon

Waiting for resolving this PR

booooohdan avatar Mar 15 '23 14:03 booooohdan

It looks like there is some conflict, can you rebase off the latest main?

chunhtai avatar Mar 23 '23 16:03 chunhtai

auto label is removed for flutter/packages, pr: 3368, Failed to merge pr#: 3368 with Pull request could not be merged: Pull Request is not mergeable.

auto-submit[bot] avatar Mar 23 '23 16:03 auto-submit[bot]

It looks like there is some conflict, can you rebase off the latest main?

Done

NazarenoCavazzon avatar Mar 23 '23 17:03 NazarenoCavazzon

grande naza!

tomassasovsky avatar Mar 23 '23 20:03 tomassasovsky

Niceeeeeeeeee

NazarenoCavazzon avatar Mar 23 '23 20:03 NazarenoCavazzon