packages icon indicating copy to clipboard operation
packages copied to clipboard

Update annotation and espresso dependencies

Open reidbaker opened this issue 2 years ago • 1 comments

Take over prs from dependabot https://github.com/flutter/packages/pull/3245 https://github.com/flutter/packages/pull/3240

reidbaker avatar Feb 22 '23 20:02 reidbaker

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Feb 22 '23 20:02 flutter-dashboard[bot]

I have a fix for the web-platform_tests CHANNEL:* PACKAGE_SHARDING:--shardIndex 0 --shardCount 2 tests here. Apologies for the breakage!

ditman avatar Feb 24 '23 23:02 ditman

There's quite a few packages that have an updated CHANGELOG.md, where nothing else changed in them (for example look at: google_maps_flutter_ios, google_maps_flutter_platform_interface, google_maps_flutter_web, camera_avfoundation...)

I think the tool let you down here and updated a bunch more that what it needed to. Reverting those files should make this PR quite smaller?

ditman avatar Feb 27 '23 21:02 ditman

I think the tool let you down here and updated a bunch more that what it needed to.

It's really easy to have the wrong base revision; I still need to change the defaults to make it less of a foot-gun.

stuartmorgan-g avatar Feb 27 '23 23:02 stuartmorgan-g

Well this is embarrassing. I am sorry I should have caught this before review. 60 reverted files now updated.

reidbaker avatar Feb 28 '23 16:02 reidbaker

@stuartmorgan in commit a6b5256 I remove the change log for packages that only have example app modifications. Can you add the label "override: no versioning needed" If you agree this pr meets the exemption requirements.

reidbaker avatar Mar 01 '23 16:03 reidbaker

Can you add the label "override: no versioning needed" If you agree this pr meets the exemption requirements.

Just updating the compile SDK definitely seems like the kind of change where overriding the standard policy is reasonable, since there's no advantage to clients in getting this change to them faster. We do the same when we bump the minimum Flutter SDK version.

(I'll document these on the wiki for the future.)

stuartmorgan-g avatar Mar 01 '23 17:03 stuartmorgan-g

@reidbaker Is this ready to merge. It has to be landed on red since it is needed to fix the tree.

bparrishMines avatar Mar 01 '23 23:03 bparrishMines