packages icon indicating copy to clipboard operation
packages copied to clipboard

[video_player] synchronize isPlaying state

Open maRci002 opened this issue 2 years ago • 11 comments

This was the original PR: flutter/plugins#7198

Resolves flutter/flutter#49081. Resolves flutter/flutter#120872.

This PR synchronizes isPlaying state between native and dart code, for example if a headset is unplugged or a phone call interrupts the video.

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • [x] I signed the CLA.
  • [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • [x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is test-exempt.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

maRci002 avatar Feb 22 '23 16:02 maRci002

Feel free to request review again when my comments in the original PR is addressed.

hellohuanlin avatar Feb 22 '23 18:02 hellohuanlin

I've addressed your comments but removing those two dependency_overrides section results error like this:

Error (Xcode): ../lib/video_player.dart:441:29: Error: Member not found: 'isPlayingStateUpdate'.

maRci002 avatar Feb 22 '23 19:02 maRci002

I've addressed your comments but removing those two dependency_overrides section results error like this: Error (Xcode): ../lib/video_player.dart:441:29: Error: Member not found: 'isPlayingStateUpdate'.

My understanding is that what you changed is the standard approach in 1p plugins. IIRC I have seen similar practice in other plugins. Without that overrides, the dependency would be the previously published version

hellohuanlin avatar Feb 22 '23 21:02 hellohuanlin

I stamped the iOS part. you probably wanna add back the reviewers for android/web.

hellohuanlin avatar Feb 23 '23 18:02 hellohuanlin

How can add back the reviewers?

maRci002 avatar Feb 23 '23 18:02 maRci002

I've added an Android test

maRci002 avatar Feb 28 '23 00:02 maRci002

Thank you for your contribution. It looks like the tests are failing. Before we can merge the PR, please see what you can do to resolve the test failures. If you are unsure how to proceed, please reach out for help on the #hackers-new channel.

reidbaker avatar Mar 02 '23 19:03 reidbaker

@reidbaker I fixed the tests.

I still need #3361 PR to be merged according to https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#changing-federated-plugins

maRci002 avatar Mar 03 '23 14:03 maRci002

This will help https://www.youtube.com/watch?v=IMQdSTlTXjA

BraveEvidence avatar Mar 15 '23 11:03 BraveEvidence

In my opinion this PR is ready

  • removed dependency_overrides
  • removed // ignore: missing_enum_constant_in_switch which was created by #3435
  • updated video_player_platform_interface dependencies to 6.1.0 since #3361 PR increased the version

maRci002 avatar Mar 16 '23 16:03 maRci002

Is this PR missing anything in order to be able to merge?

gmackall avatar Mar 23 '23 18:03 gmackall

Is this PR missing anything in order to be able to merge?

Seems ready to me.

tarrinneal avatar Mar 23 '23 19:03 tarrinneal