packages
packages copied to clipboard
[go_router_builder]: ShellRoute support
This PR adds possibility to generate shell routes from the newest 5.0.0 API.
flutter/flutter#111909
Pre-launch Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
- [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use
dart format
.) - [x] I signed the CLA.
- [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences]
- [x] I listed at least one issue that this PR fixes in the description above.
- [x] I updated
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes. - [x] I updated
CHANGELOG.md
to add a description of the change, following repository CHANGELOG style. - [x] I updated/added relevant documentation (doc comments with
///
). - [x] I added new tests to check the change I am making, or this PR is test-exempt.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
@chunhtai Hi! It is my first contribution here. Looks like you've reviewed previous PR about go_router.
The go_router change need to go in with a separate pr first, can you open a new one and move the go_router change there?
of course, but how to depend on it, so go_router_builder can see new APIs? Or when the changes approved for go_router, then we publish new library ver and after it we start implementing the go_router_builder stuff? @chunhtai
of course, but how to depend on it, so go_router_builder can see new APIs? Or when the changes approved for go_router, then we publish new library ver and after it we start implementing the go_router_builder stuff? @chunhtai
yes, once the go_router change is merged, the go_router_builder should be able to see the change, we will need to bump the go_router version in example folder though
understood, thank you! i will do the changes in go_router and remove them from this PR.
@hawkkiller any update on this?
@hawkkiller Are you still planning on updating this PR based on the feedback above?
@stuartmorgan @Skogsfrae check this https://github.com/flutter/packages/pull/2730 but thanks for the reminder :)