packages icon indicating copy to clipboard operation
packages copied to clipboard

[dynamic_layouts] Clean up remaining TODOs

Open Piinks opened this issue 1 year ago • 2 comments

This cleans up the remaining TODOs in the dynamic_layouts package.

Filed https://github.com/flutter/flutter/issues/112234 for follow up on the remaining garbage collection issue.

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • [x] I signed the CLA.
  • [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • [ ] I listed at least one issue that this PR fixes in the description above.
  • [ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • [ ] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [ ] I added new tests to check the change I am making, or this PR is test-exempt.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Piinks avatar Sep 22 '22 22:09 Piinks

Is this ready to land?

stuartmorgan avatar Oct 10 '22 19:10 stuartmorgan

Sorry, no. I have a few nits to clean up. Updating now. :)

Piinks avatar Oct 13 '22 15:10 Piinks