packages
packages copied to clipboard
flutter
[adaptive_scaffold] New and Improved Helper Widgets & Updated Examples and Their Tests
https://github.com/flutter/packages/pull/2406
Added builders and logic to the existing merged pull request above and updated examples and their respective tests.
You will also want to run flutter pub global activate flutter_plugin_tools && flutter pub global run flutter_plugin_tools format once you've fixed the lints to catch the remaining formatting/tab issues.
Also you will want to remove the <?code-excerpt ...> s from the README.md and remove the ! from before the for the images.
You will want to add this file https://github.com/flutter/plugins/blob/main/packages/local_auth/local_auth/example/build.excerpt.yaml to the example directory. The problem with code-excerpts should be resolved by this document https://github.com/flutter/flutter/wiki/Contributing-to-Plugins-and-Packages#readme-code.
Edit: Actually, this takes a little more effort so I'll chat with you once you're ready.
You will also want to add a link to this issue: https://github.com/flutter/flutter/issues/109278 at the bottom of the adaptive_layout_test in the comment regarding why some tests are currently disabled.
You will want to add:
dev_dependencies:
build_runner: ^2.1.10
to your example pubsec.yaml
Not sure if this could also be an issue but pointing it out just in case. Do we have permission to use the title/text of the sample emails in the demo?
Not sure if this could also be an issue but pointing it out just in case. Do we have permission to use the title/text of the sample emails in the demo?
Depends on the source. If it came from an internal source, it's fine. If it was copied from somewhere else, then we should replace the text with something else.
If you just need filler text, you can generate it here: https://www.lipsum.com/
What's the status of this PR? Is it waiting for updates, or for another round of reviews?
Sorry, this is no longer relevant. The content was merged in another PR.