packages icon indicating copy to clipboard operation
packages copied to clipboard

[go_router] adds async feature and build context to redirect

Open chunhtai opened this issue 3 years ago • 1 comments

fixes https://github.com/flutter/flutter/issues/105808 fixes https://github.com/flutter/flutter/issues/99121

Pre-launch Checklist

  • [ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [ ] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • [ ] I signed the CLA.
  • [ ] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • [ ] I listed at least one issue that this PR fixes in the description above.
  • [ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • [ ] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [ ] I added new tests to check the change I am making, or this PR is test-exempt.
  • [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

chunhtai avatar Aug 08 '22 22:08 chunhtai

This pull request was opened against a branch other than main. Since Flutter pull requests should not normally be opened against branches other than main, I have changed the base to main. If this was intended, you may modify the base back to go_router_v5. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than main, unless this is an intentional hotfix/cherrypick.

flutter-dashboard[bot] avatar Aug 08 '22 22:08 flutter-dashboard[bot]

The ci is failing due to flutter sdk version mismatched, may need some more time to figure out, otherwise the code is ready

chunhtai avatar Aug 22 '22 20:08 chunhtai

@loic-sharma PTAL :)

chunhtai avatar Aug 29 '22 20:08 chunhtai