packages icon indicating copy to clipboard operation
packages copied to clipboard

[camera_avfoundation] Wrappers swift migration - part 4

Open RobertOdrowaz opened this issue 1 month ago • 3 comments

Migrates camera wrappers as part of https://github.com/flutter/flutter/issues/119109

This PR migrates wrappers to Swift:

  • FLTCaptureConnection
  • FLTCaptureDeviceFormat
  • FLTAssetWriter

In line with Swift conventions, the FLT prefixes are removed. The Default class implementations are replaced with protocol conformance on base AV classes.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

RobertOdrowaz avatar Nov 16 '25 11:11 RobertOdrowaz

@hellohuanlin pls take a look at this PR again when you have some time

RobertOdrowaz avatar Nov 20 '25 15:11 RobertOdrowaz

Is this ready for another pass?

hellohuanlin avatar Dec 03 '25 17:12 hellohuanlin

@hellohuanlin It's ready now. I've reverted the error handling and will open an issue once this is merged

RobertOdrowaz avatar Dec 10 '25 05:12 RobertOdrowaz

@hellohuanlin pls take a look again when you have some time

RobertOdrowaz avatar Dec 17 '25 05:12 RobertOdrowaz

Sorry, I have been working on an urgent bug. Will take a look later this week.

hellohuanlin avatar Dec 17 '25 05:12 hellohuanlin