packages icon indicating copy to clipboard operation
packages copied to clipboard

[webview_flutter] Disable legacy Android video poster

Open lauweijie opened this issue 2 months ago • 7 comments

It looks like the chromium team is considering disabling the default video poster feature: https://issues.chromium.org/issues/40755557. This changes it to an empty bitmap for now.

Fixes https://github.com/flutter/flutter/issues/178263.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

lauweijie avatar Nov 10 '25 22:11 lauweijie

Opted out to land in downstream fork for now.

bparrishMines avatar Nov 11 '25 19:11 bparrishMines

An existing Git SHA, ab5b85c8b01177f3673950a056c7f188b116b505, was detected, and no actions were taken.

To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with --force) that already was pushed before, push a blank commit (git commit --allow-empty -m "Trigger Build") or rebase to continue.

fluttergithubbot avatar Nov 11 '25 20:11 fluttergithubbot

@lauweijie is this ready for review or did you want it to be a draft?

reidbaker avatar Nov 11 '25 21:11 reidbaker

@reidbaker I set this as a draft while we wait to see what the process will be to roll this plugin internally. It's only open still to ensure that we revisit it after a decision. But I'm also open to closing it for now if it is easier for triage teams.

bparrishMines avatar Nov 12 '25 17:11 bparrishMines

I just wanted to make sure that it wasn't accidentally marked as draft.

reidbaker avatar Nov 12 '25 17:11 reidbaker

From triage: @lauweijie are you still planning on updating this to make it an option, so that we can land it upstream?

stuartmorgan-g avatar Dec 02 '25 19:12 stuartmorgan-g

Not currently, I'll come back to this when I have more time to make it configurable as an option. I guess there are two ways to do this: one is to have a boolean option to decide if we should disable the default poster behavior (and override it with the empty bitmap), another option is to allow flutter to provide the bitmap. Happy for someone else to take this up.

lauweijie avatar Dec 03 '25 15:12 lauweijie