packages icon indicating copy to clipboard operation
packages copied to clipboard

feat(ios): add audio track selection support for AVFoundation

Open nateshmbhat opened this issue 2 months ago • 9 comments

  • Implemented getAudioTracks() method to retrieve available audio tracks from both HLS streams and regular video files

AVFoundation Platform PR for : #9925

Pre-Review Checklist

  • [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [x] I read the [Tree Hygiene] page, which explains my responsibilities.
  • [x] I read and followed the [relevant style guides] and ran [the auto-formatter].
  • [x] I signed the [CLA].
  • [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • [x] I [linked to at least one issue that this PR fixes] in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].
  • [x] I updated CHANGELOG.md to add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].
  • [x] I updated/added any relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • [x] All existing and new tests are passing.

nateshmbhat avatar Oct 28 '25 15:10 nateshmbhat

@LongCatIsLooong @tarrinneal could you please review this PR

nateshmbhat avatar Nov 07 '25 17:11 nateshmbhat

any update on this ?

nateshmbhat avatar Nov 14 '25 15:11 nateshmbhat

any update on this ? 🙏🏻 @tarrinneal @LongCatIsLooong

nateshmbhat avatar Nov 19 '25 14:11 nateshmbhat

🥲

nateshmbhat avatar Nov 24 '25 06:11 nateshmbhat

🥲

Sorry, I've been out as my wife is recovering from surgery. I'll try to get to this in the next couple days.

tarrinneal avatar Nov 24 '25 19:11 tarrinneal

(just started reviewing this, I'll finish doing the review tomorrow, sorry for the delay I was working on a bugfix).

LongCatIsLooong avatar Nov 25 '25 00:11 LongCatIsLooong

@LongCatIsLooong thanks for the detailed review. Have addressed all the comments, can you please check ?

nateshmbhat avatar Nov 27 '25 08:11 nateshmbhat

any update on this guys ? 😄 The android PR got approved with all checks passing ✅ and is about to get merged. It would be great if this IOS PR also can be reviewed.

i'm willing to quickly address any comments and make required changes. please do the needful from your side and support in getting this PR landed.

nateshmbhat avatar Dec 09 '25 16:12 nateshmbhat

any update on this guys ?

@nateshmbhat I have asked you several times on these PRs to stop pinging people for updates/reviews. We have a regular process for following up on reviews, and will handle reminders within the team as necessary.

please do the needful from your side and support in getting this PR landed.

Delays in review happen because everyone involved in the reviews has a lot of work they are balancing. The problem is not that the Flutter team does not understand what their jobs entail, and implying otherwise is disrespectful to the team.

stuartmorgan-g avatar Dec 09 '25 17:12 stuartmorgan-g