[flutter_svg] Add `SvgPicture.precompiled` constructor
flutter_svg allows precompiled SVG files, see Precompiling and Optimizing SVGs.
However, as a developer, you have to add three things to your code:
- Add
vector_graphicsas a direct dependency - Add
import 'package:vector_graphics/vector_graphics.dart';import - Use additionally the
AssetBytesLoaderclass.
With SvgPicture.precompiled(String assetName, [...]) a developer of the package can use precompiled SVG files without the three steps above.
Closes https://github.com/flutter/flutter/issues/177068
Pre-Review Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I read the Tree Hygiene page, which explains my responsibilities.
- [x] I read and followed the relevant style guides and ran the auto-formatter.
- [x] I signed the CLA.
- [x] The title of the PR starts with the name of the package surrounded by square brackets, e.g.
[shared_preferences] - [x] I linked to at least one issue that this PR fixes in the description above.
- [x] I updated
pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under[^1]. - [x] I updated
CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under[^1]. - [x] I updated/added any relevant documentation (doc comments with
///). - [x] I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under[^1].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.
[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
@domesticmouse Thanks for your quick review! Do you have feedback for the questions that I posted?
PTAL @stuartmorgan-g
PTAL @stuartmorgan-g
Since this is expanding the API surface, it should be signed off by someone from the engine team, since that's the team that has primary ownership of the package. I'll leave a comment on the issue.
From triage: @chinmaygarde Are the packages in this repo owned by the engine team being included in engine team triage? (If not, the triage-engine label is an easy way to pick up all of them with one query).
From triage: Ping @chinmaygarde on the question above.
We recently found that the filters used for issue triage (go/flutter-engine-triage-playbook) were ignoring SVG and vector graphics issues. I think a similar fix needs to be applied for PR triage. While the label is good, we were not looking in this repo for PRs.