gallery icon indicating copy to clipboard operation
gallery copied to clipboard

Gallery app would like a way to report crashes

Open sethladd opened this issue 8 years ago • 15 comments

We'd like to capture and measure crashes in the wild. We should find a good way to do this in Flutter apps.

Perhaps we can try https://firebase.google.com/docs/crash/

sethladd avatar May 20 '16 16:05 sethladd

Implementing this might provide insight for https://github.com/flutter/flutter/issues/614

sethladd avatar May 20 '16 16:05 sethladd

cc @collinjackson who was interested in trying out Firebase Crash Reporting + Flutter

sethladd avatar May 23 '16 21:05 sethladd

Moving this to Gallery-Next since we have 2 other customers asking for this and should pave the way for them with the Gallery.

eseidelGoogle avatar May 31 '16 17:05 eseidelGoogle

(Assuming we mean a C crash and not just an unhandled Dart exception.)

Currently precompilation supports two ways of outputting instructions, either outputting an assembly file that can be turned into a shared library that can be loaded with dlopen or outputting a binary blob that can be loaded with mmap. On iOS, Flutter uses the shared library approach (mmap can't create executable pages, which enforces the no-JITing policy) and as a benefit the native debugging tools have symbols for the precompiled Dart code. On Android, the binary blob approach is used to avoid a build step that requires the NDK on developer machines, but this means there are no symbols for precompiled Dart code. Getting symbols for precompiled code on Android might mean switching to shared libraries, or it might mean we need to output some kind of symbol blob as well, though what format would depending on what tool would be symbolizing the traces.

rmacnak-google avatar May 31 '16 23:05 rmacnak-google

I don't think we are implementing Firebase Crash (Google is recommending NOT to use Firebase for crash reporting on new projects anymore) and adding Crashlytics is covered by flutter/flutter#9592. So I think this issue is just about adding crash reporting to the Gallery, possibly with package:sentry.

Unassigned myself since I'm not currently working on that.

collinjackson avatar Aug 14 '17 17:08 collinjackson

cc @yjbanov is this done?

Hixie avatar Oct 17 '17 22:10 Hixie

cc @sethladd is this done?

Hixie avatar Oct 17 '17 22:10 Hixie

Not done. Would be perfect for a DPE. I'd like for a DPE to help us "dogfood" our crash reporting, and provide a sample/example.

sethladd avatar Oct 17 '17 22:10 sethladd

Ideally we'd just use whatever we tell other people to use, once we have an answer to that.

Hixie avatar Dec 19 '18 01:12 Hixie

Right now the best we have is probably package:sentry with https://github.com/flutter/crashy as an example of using it. Once we have a more complete Crashlytics package that would be a good one to use here: https://github.com/flutter/flutter/issues/14765

eseidelGoogle avatar Dec 19 '18 01:12 eseidelGoogle

We may also be able to use the same thing we use for flutter command-line tools (see crash_reporting.dart).

yjbanov avatar Dec 19 '18 01:12 yjbanov

Can we close this in favor of https://github.com/flutter/gallery/issues/632 ?

amanv8060 avatar Apr 08 '22 09:04 amanv8060

cc/ @guidezpl

amanv8060 avatar Apr 08 '22 09:04 amanv8060

This has more history, so let me move it to the repo, and use this for tracking

guidezpl avatar Apr 08 '22 10:04 guidezpl

https://play.google.com/console/ with the Flutter stores account gives some, but limited info on crashes. Which solution to use (e.g. crashlytics, sentry) is unclear. This will probably have to be done by a team member given the need to access and store private keys.

guidezpl avatar Apr 08 '22 10:04 guidezpl

https://github.com/flutter/gallery/pull/908 Updated the gallery to use Firebase Crashlytics as well Firebase Performance monitoring.

Visit those links for help on setting them up with Flutter :)

parlough avatar Jan 13 '24 03:01 parlough