gallery icon indicating copy to clipboard operation
gallery copied to clipboard

Move valuable sample code to relevant packages or framework

Open guidezpl opened this issue 1 year ago • 5 comments
trafficstars

In my view, these are the most valuable demos:

  • TwoPane → dual_screen cc @andreidiaconu

    • image
  • Material/Cupertino demos: they should be nearly all already covered by https://github.com/flutter/flutter/issues/102812, however, one may want to move individual gallery demos to a sample in the framework for the relevant API. cc @gspencergoog

guidezpl avatar Jan 11 '24 15:01 guidezpl

  • Motion → animations cc @stuartmorgan

@goderbauer is the primary owner of animations.

stuartmorgan-g avatar Jan 11 '24 17:01 stuartmorgan-g

@guidezpl Could you link to the motion sample code that you have in mind?

goderbauer avatar Jan 11 '24 17:01 goderbauer

They're in https://github.com/flutter/gallery/tree/main/lib/demos/reference, each starting with motion_

guidezpl avatar Jan 12 '24 08:01 guidezpl

Those examples already exist in package:animations, see https://github.com/flutter/packages/tree/main/packages/animations/example/lib. I suspect, that they were actually copied from that package (with minor modifications like adding localizations) to the gallery 😄. I think we can remove these from the list of potential candidate for a move.

goderbauer avatar Jan 12 '24 17:01 goderbauer

Indeed, with slightly modified names and a combined axis demo. For posterity, the demo looked as follows

image

guidezpl avatar Jan 15 '24 14:01 guidezpl