flutter icon indicating copy to clipboard operation
flutter copied to clipboard

[tool] Removes deprecated --web-renderer parameter.

Open ditman opened this issue 1 year ago • 2 comments

Removes the --web-renderer option.

Flutter tool users won't be able to select their web renderer.

In order to not drop test coverage, tests are still run with the HTML Renderer, until its code is fully removed from the engine.

Part of https://github.com/flutter/flutter/issues/145954

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

ditman avatar Nov 22 '24 02:11 ditman

Publishing this PR to have CI take a look. I fully expect this to fail.

0b0d048c-fd01-4136-a025-d4983c8ab082_text

ditman avatar Nov 22 '24 02:11 ditman

The problem was that I was not using the correct renderer on flutter run/drive. Now I've corrected this (4a2ae1d), and tests should pass, unless I broke some by changing the errors. 🤞

ditman avatar Nov 23 '24 01:11 ditman

In test_6, it seems the runner is doing:

`/work/flutter/flutter/bin/cache/flutter_web_sdk/ --incremental --target=dartdevc --experimental-emit-debug-metadata -DFLUTTER_WEB_AUTO_DETECT=false -DFLUTTER_WEB_USE_SKIA=false -DFLUTTER_WEB_USE_SKWASM=false -DDART_HHH_BOT=false -DFLUTTER_WEB_USE_SKIA=true --output-dill ...

That's probably not good :)

ditman avatar Nov 26 '24 01:11 ditman

All right, down to 1 failing test!

ditman avatar Nov 26 '24 02:11 ditman

All is green, I'll set this to autosubmit next week.

ditman avatar Nov 27 '24 23:11 ditman