flutter icon indicating copy to clipboard operation
flutter copied to clipboard

[`ThemeData` 🧹] Remove `primaryColorLight` & `primaryColorDark` usages

Open guidezpl opened this issue 3 years ago • 1 comments

This prepares the deprecation of this property by removing framework usages.

  • Inlines a suitable default for CircleAvatar

The deprecation and a Dart fix will be in https://github.com/flutter/flutter/pull/116369.

Part of https://github.com/flutter/flutter/issues/91772

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • [x] I signed the CLA.
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is test-exempt.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

guidezpl avatar Dec 01 '22 16:12 guidezpl

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Dec 01 '22 16:12 flutter-dashboard[bot]