flutter icon indicating copy to clipboard operation
flutter copied to clipboard

[codelabs]: Boring to Beautiful Code snippets marked up incorrectly

Open wednesdei opened this issue 1 year ago • 1 comments

The following codelab:

https://codelabs.developers.google.com/codelabs/flutter-boring-to-beautiful#2

Uses a dark-to-light icon that changes the background of the code snippet section from dark to light. It should be a copy icon, which copies the code snippet to the clipboard.

Please replace theme changing icon + action to copy icon + copy action

wednesdei avatar Oct 18 '22 21:10 wednesdei

/cc @domesticmouse

darshankawar avatar Oct 19 '22 07:10 darshankawar

Fix is in flight.

Googlers: cl/513441101

domesticmouse avatar Mar 02 '23 06:03 domesticmouse

I was working on a new codelab today and noticed the same issue here: https://codelabs.developers.google.com/codelabs/flutter-animated-responsive-layout?hl=en#0

Screenshot 2023-03-02 132514

Does the fix apply to all the existing codelabs, or just the one I identified above? Thanks for making the fix :)

ghost avatar Mar 02 '23 20:03 ghost

Looks like I need to dig deeper

domesticmouse avatar Mar 03 '23 02:03 domesticmouse

Googlers: cl/513733889

domesticmouse avatar Mar 03 '23 06:03 domesticmouse

Running cl/533658168 as an update to see if the codelabs backend is fixed. I can't see the differences in the generated markdown.

le sigh

domesticmouse avatar May 20 '23 07:05 domesticmouse

The missing copy icon issue is tracked in https://github.com/flutter/flutter/issues/128081

domesticmouse avatar Jun 10 '23 23:06 domesticmouse

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

github-actions[bot] avatar Jun 26 '23 06:06 github-actions[bot]