flutter icon indicating copy to clipboard operation
flutter copied to clipboard

[Impeller] Migrate the Embedder API to use Impeller.

Open chinmaygarde opened this issue 2 years ago • 5 comments

Migrating to Impeller will not change the public Embedder API in any way. But, Impeller needs to be wired up as a backend.

chinmaygarde avatar Sep 22 '22 22:09 chinmaygarde

From the Impeller Weekly sync: This would also allow us to use the embedder test harnesses on Mac as Impeller smoke tests. Elevating priority and assigning.

chinmaygarde avatar Sep 28 '22 22:09 chinmaygarde

Making good progress on this. Should land this for Metal this week.

chinmaygarde avatar Oct 03 '22 19:10 chinmaygarde

@chinmaygarde I see you unassigned yourself, did you have any updates about this? It's a blocker for https://github.com/flutter/flutter/issues/112232.

jmagman avatar Dec 29 '22 21:12 jmagman

I think I messed up the priorities. Will put this back on the docket for January.

Re. https://github.com/flutter/flutter/issues/112232, the Impeller migration will not affect the embedder API. So you should be able to complete the switch of iOS to that API without the Impeller transition getting in the way. When Impeller becomes the default however, this will definitely be a blocker. We'll have this issue sorted well before then hopefully.

I'm curious how you're orchestrating the migration in https://github.com/flutter/flutter/issues/112232. I expect a temporary shim to allow you to swap between the Embedder API and the current embeddings. But, I could be mistaken. Happy to have a call with @cyanglaz and others with sort it out.

chinmaygarde avatar Dec 29 '22 23:12 chinmaygarde

I'm curious how you're orchestrating the migration in #112232. I expect a temporary shim to allow you to swap between the Embedder API and the current embeddings.

Yes, it will be something similar to how we enable impeller. I'm going to prepare a doc for the migration and I'd be appreciate to have a call to sort it out after the initial draft doc is ready.

cyanglaz avatar Jan 05 '23 17:01 cyanglaz

Sounds good. Let's have a quick sync when you are done with the doc.

chinmaygarde avatar Jan 05 '23 20:01 chinmaygarde

This was completed by @jonahwilliams and the desktop embedder on macOS is already using it and is ready for preview.

chinmaygarde avatar Jul 13 '23 04:07 chinmaygarde

Technically we don't support opting into impeller if you select kSoftware or kVulkan.

jonahwilliams avatar Jul 13 '23 04:07 jonahwilliams

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

github-actions[bot] avatar Jul 27 '23 05:07 github-actions[bot]