flutter icon indicating copy to clipboard operation
flutter copied to clipboard

Add support for font variation based theming to `Icon`

Open guidezpl opened this issue 3 years ago • 1 comments

Followup to https://github.com/flutter/flutter/pull/106896.

https://github.com/flutter/flutter/issues/102560

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • [x] I signed the CLA.
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is test-exempt.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

guidezpl avatar Aug 08 '22 10:08 guidezpl

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #109140 at sha 105c4171ce868480b4f39b7d0fb4743abe892d97

flutter-dashboard[bot] avatar Aug 08 '22 17:08 flutter-dashboard[bot]

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #109140 at sha 23c40118aae7782251db4255b7cd1bd25313cdc8

flutter-dashboard[bot] avatar Aug 09 '22 03:08 flutter-dashboard[bot]