engine icon indicating copy to clipboard operation
engine copied to clipboard
verified publisher icon flutter

Fixes crash in testTrackpadGesturesAreSentToFramework

Open gaaclarke opened this issue 1 year ago • 2 comments

fixes https://github.com/flutter/flutter/issues/157205

This crashed because ocmock was storing references to rvalues for its mocked arguments.

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I signed the CLA.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gaaclarke avatar Oct 21 '24 17:10 gaaclarke

I reverted the change to run_tests.py since there appears to be some other issues with that test runner, not just the one that I fixed. I still think this is going to unblock Zach's move to arm64 bots without disabling more tests though since I could reproduce that problem locally.

gaaclarke avatar Oct 21 '24 21:10 gaaclarke

Thanks for tracking this down! I'm not familiar with this code, so will defer to @cbracken and @loic-sharma.

zanderso avatar Oct 21 '24 21:10 zanderso