engine
engine copied to clipboard
web ui: fix autofill email input type for detection by proton pass
This pull request enhances the autofill functionality in the text editing engine by adding support for email and username hints. It also includes corresponding unit tests to verify the new functionality.
Enhancements to Autofill Functionality:
- Updated the
AutofillInfoclass to handle email hints by setting the input element type to 'email' when the autofill hint contains 'email'.
Unit Tests:
- Added constants for email and username hints in the
testMainfunction. - Introduced tests to verify the correct behavior of email and username autofill hints, ensuring that the input element's type, name, id, and autocomplete attributes are set appropriately.
Fixes Issue #156235
Pre-launch Checklist
- [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
- [x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
- [x] I listed at least one issue that this PR fixes in the description above.
- [X] I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
- [X] I updated/added relevant documentation (doc comments with
///). - [X] I signed the CLA.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.