engine icon indicating copy to clipboard operation
engine copied to clipboard

[WIP] expose Semantics.identifier as Windows UIA AutomationId

Open nicerloop opened this issue 1 year ago • 7 comments

Expose Semantics.identifier as Windows AutomationId to ease application automation.

see https://github.com/flutter/flutter/issues/148763

replaces https://github.com/flutter/engine/pull/53476

Pre-launch Checklist

  • [X] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • [X] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • [X] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • [X] I listed at least one issue that this PR fixes in the description above.
  • [ ] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [ ] I signed the [CLA].
  • [ ] All existing and new tests are passing.

I don't know how/where I can add tests for this feature.

CLA signing requires my employer to find/define who will sign.

2 tests fail to pass on Windows, both before and after my modifications:

  • engine\src\out\host_debug_unopt\flutter_windows_unittests.exe KeyboardTest.DeadKeyTwiceThenLetter
  • engine\src\out\host_debug_unopt\flutter_windows_unittests.exe KeyboardTest.DeadKeyWithoutDeadMaskThatCombines

nicerloop avatar Jul 04 '24 12:07 nicerloop

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jul 04 '24 12:07 google-cla[bot]

Hi @nicerloop thanks for fixing the test failures. Please be aware that we cannot review any patch until we have a signed CLA on file. Let us know once that's done and we'll take a look!

cbracken avatar Jul 12 '24 17:07 cbracken

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

flutter-dashboard[bot] avatar Aug 07 '24 01:08 flutter-dashboard[bot]

Hi @nicerloop, are you still working on this?

cbracken avatar Aug 16 '24 17:08 cbracken

Hi,

I am currently on vacation, and I am still waiting for official CLA signature from my employer. The original need remains and I will get back to work on this PR in september.

nicerloop avatar Aug 16 '24 20:08 nicerloop

@nicerloop Hey there, we can't review this until the CLA is completed. I'll convert this to a draft for now, feel free to change it back once this is ready for review. Thanks for the contribution!

loic-sharma avatar Sep 23 '24 17:09 loic-sharma

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

flutter-dashboard[bot] avatar Sep 23 '24 17:09 flutter-dashboard[bot]

Since we've had no response on this patch, we're going to close it for now. @nicerloop, once you've got any permissions you need on the CLA side of things, please re-open a new patch and we'll gladly review.

cbracken avatar Nov 20 '24 22:11 cbracken