engine icon indicating copy to clipboard operation
engine copied to clipboard

[flutter_releases] Flutter stable 3.22.3 Engine Cherrypicks

Open itsjustkevin opened this issue 1 year ago • 4 comments

Flutter stable 3.22.3 Engine

Scheduled Cherrypicks

  • Roll dart revision: dart-lang/sdk@604651494

Dart

  • https://github.com/dart-lang/sdk/issues/55979
  • https://github.com/dart-lang/sdk/issues/55943

Engine

  • https://github.com/flutter/flutter/issues/149700
  • https://github.com/flutter/flutter/issues/149701
  • https://github.com/flutter/flutter/issues/149702
  • https://github.com/flutter/flutter/issues/149704
  • https://github.com/flutter/flutter/issues/149745
  • https://github.com/flutter/flutter/issues/149771
  • https://github.com/flutter/engine/pull/53183

itsjustkevin avatar Jul 02 '24 15:07 itsjustkevin

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

flutter-dashboard[bot] avatar Jul 02 '24 15:07 flutter-dashboard[bot]

________ running 'cipd ensure -log-level info -root C:\b\s\w\ir\cache\builder -ensure-file C:\b\s\w\ir\x\t\tmpqrmxhpug.ensure' in '.'
Errors:
  failed to resolve flutter/dart-sdk/windows-arm64@git_revision:60465149414572c8ca189d8f65fdb39795c4b97d (line 14): ambiguity when resolving the tag, more than one instance has it
Error: Command 'cipd ensure -log-level info -root C:\\b\\s\\w\\ir\\cache\\builder -ensure-file C:\\b\\s\\w\\ir\\x\\t\\tmpqrmxhpug.ensure' returned non-zero exit status 1
Errors:
  failed to resolve flutter/dart-sdk/windows-arm64@git_revision:60465149414572c8ca189d8f65fdb39795c4b97d (line 14): ambiguity when resolving the tag, more than one instance has it

I think we messed up and created duplicate tags

christopherfujino avatar Jul 02 '24 19:07 christopherfujino

________ running 'cipd ensure -log-level info -root C:\b\s\w\ir\cache\builder -ensure-file C:\b\s\w\ir\x\t\tmpqrmxhpug.ensure' in '.'
Errors:
  failed to resolve flutter/dart-sdk/windows-arm64@git_revision:60465149414572c8ca189d8f65fdb39795c4b97d (line 14): ambiguity when resolving the tag, more than one instance has it
Error: Command 'cipd ensure -log-level info -root C:\\b\\s\\w\\ir\\cache\\builder -ensure-file C:\\b\\s\\w\\ir\\x\\t\\tmpqrmxhpug.ensure' returned non-zero exit status 1
Errors:
  failed to resolve flutter/dart-sdk/windows-arm64@git_revision:60465149414572c8ca189d8f65fdb39795c4b97d (line 14): ambiguity when resolving the tag, more than one instance has it

I think we messed up and created duplicate tags

Filing a tracking issue for this: https://github.com/flutter/flutter/issues/151206

christopherfujino avatar Jul 03 '24 00:07 christopherfujino

________ running 'cipd ensure -log-level info -root C:\b\s\w\ir\cache\builder -ensure-file C:\b\s\w\ir\x\t\tmpqrmxhpug.ensure' in '.'
Errors:
  failed to resolve flutter/dart-sdk/windows-arm64@git_revision:60465149414572c8ca189d8f65fdb39795c4b97d (line 14): ambiguity when resolving the tag, more than one instance has it
Error: Command 'cipd ensure -log-level info -root C:\\b\\s\\w\\ir\\cache\\builder -ensure-file C:\\b\\s\\w\\ir\\x\\t\\tmpqrmxhpug.ensure' returned non-zero exit status 1
Errors:
  failed to resolve flutter/dart-sdk/windows-arm64@git_revision:60465149414572c8ca189d8f65fdb39795c4b97d (line 14): ambiguity when resolving the tag, more than one instance has it

I think we messed up and created duplicate tags

Filing a tracking issue for this: flutter/flutter#151206

I removed the tag from https://chrome-infra-packages.appspot.com/p/flutter/dart-sdk/windows-arm64/+/Yl9L7nIDSTcAgDFj9Q7Ce8jggdMszxCVHDT9hYMwoCMC, and have re-scheduled the windows presubmits

christopherfujino avatar Jul 03 '24 00:07 christopherfujino

Per https://github.com/flutter/flutter/issues/151558, I also cherrypicked https://github.com/flutter/engine/commit/ae9e09285c8a6b73d6d6a47652d8cc835639a1e1#diff-6608483a47ebedf1d8d4a0cb1e8c306dbed52fb5c1fc1485bdc48e2d99bdb0a1 to this branch

christopherfujino avatar Jul 10 '24 22:07 christopherfujino

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #53686 at sha 133e8a80d1dcb109c06810ac32888229579f3c0a

flutter-dashboard[bot] avatar Jul 12 '24 19:07 flutter-dashboard[bot]

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #53686 at sha 133e8a8

To work around this, I pushed a commit (https://github.com/flutter/engine/pull/53686/commits/2bebadaf3c1ec9a2eda34ab5cf8dfef9df4fffed) deleting the impeller tests (I don't believe we ever ran golden tests on this branch previously), similar to this change on the 3.23 branch: https://github.com/flutter/engine/pull/53178

christopherfujino avatar Jul 12 '24 20:07 christopherfujino