engine icon indicating copy to clipboard operation
engine copied to clipboard

Remove default for `stripped` option, don't strip by default on android

Open gmackall opened this issue 1 year ago • 1 comments
trafficstars

This is round 3, after https://github.com/flutter/engine/pull/50443 and https://github.com/flutter/engine/pull/51394. I think this is finally the right place to make the change, if this gn actually works.

Always respect the stripped argument if it is passed, but otherwise default to not stripping on android, and stripping on other platforms.

Still need to do some testing before landing, but making the PR so that this stays on my radar

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • [ ] I listed at least one issue that this PR fixes in the description above.
  • [x] I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I signed the CLA.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gmackall avatar May 15 '24 17:05 gmackall

Picking this back up.

Need to figure out why AGP doesn't strip the resultant appbundle properly when the NDK version isn't downloaded.

gmackall avatar Sep 03 '24 22:09 gmackall

@gmackall post-monorepo can you recreate this in the framework and close this engine PR (especially since you landed the ndk download)?

jmagman avatar Jan 07 '25 06:01 jmagman

https://github.com/flutter/flutter/pull/161546

gmackall avatar Jan 13 '25 20:01 gmackall