engine icon indicating copy to clipboard operation
engine copied to clipboard

[Embedder API] Add multi-view present callback

Open loic-sharma opened this issue 11 months ago • 3 comments

Adds FlutterCompositor.present_view_callback to the embedder API. This new present callback adds a view_id member to allow embedders know which view is being presented.

The embedder API does not allow embedders to create multiple views yet. This will be added in a future pull request.

Design doc: https://flutter.dev/go/multi-view-embedder-apis

Pull request that migrates the Windows embedder to this new embedder API: https://github.com/flutter/engine/pull/51293

Part of https://github.com/flutter/flutter/issues/144806 Part of https://github.com/flutter/flutter/issues/142845

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I signed the CLA.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

loic-sharma avatar Mar 07 '24 22:03 loic-sharma

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

flutter-dashboard[bot] avatar Mar 08 '24 00:03 flutter-dashboard[bot]

@cbracken or @chinmaygarde Would you be able to review the changes in embedder.h from an ABI standpoint?

loic-sharma avatar Mar 12 '24 15:03 loic-sharma

Taking a look!

cbracken avatar Mar 12 '24 18:03 cbracken