Revert text cursor position calculation windows
Reverts the logic for calculating the TextField input text cursor position when inputting Korean characters (3.13.9)
- Issue occurred since 3.16.x
- https://github.com/flutter/flutter/issues/140739
List which issues are fixed by this PR. You must list at least one issue.
- When entering Korean text, the input cursor must be located on the right side of the input text. However, when entering Korean text, the input cursor is located to the left of the entered character.
Recorded Video about the issue:
-
Before (origin/main): https://github.com/flutter/engine/assets/121159478/25d86b34-677c-4bc4-bc5e-b0179f36484c
-
Modified (origin/revert_text_cursor_position_calculation_windows) https://github.com/flutter/engine/assets/121159478/7a53799f-7c1d-404b-be33-d4568b9a001c
Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
- [ ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
- [ ] I listed at least one issue that this PR fixes in the description above.
- [ ] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with
///). - [ ] I signed the [CLA].
- [ ] All existing and new tests are passing.
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).
If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?
Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.
@LongCatIsLooong this is related to your changes in https://github.com/flutter/engine/pull/49314, would you be able to review this?
Hi @deniz-lee are you planning to follow up on the code review suggestions?
If not, could you please close this PR to get it off of our review queue?
(Desktop triage)
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.