engine icon indicating copy to clipboard operation
engine copied to clipboard
verified publisher icon flutter

[Impeller] Support binding multiple vertex buffer views.

Open bdero opened this issue 2 years ago • 5 comments

Resolves https://github.com/flutter/flutter/issues/116168.

Makes it possible for us to use arbitrary vertex layouts, including SoA layouts with attributes stored in different DeviceBuffers.

bdero avatar Jan 10 '24 10:01 bdero

I'm strongly considering std::variant<BufferView, std::vector<BufferView>> vertex_buffers

I know it seems cringe on the surface, but hear me out:

  • No funky business on the assignment side.
  • On the consumer side, we're forced to deal with both cases either way.

bdero avatar Jan 10 '24 20:01 bdero

that seems reasonable to me, am I crazy 🤔

jonahwilliams avatar Jan 10 '24 20:01 jonahwilliams

Need to rewrite this for the new command encoding interface, keeping it in draft for a while longer until I have time to iterate.

bdero avatar Jan 22 '24 23:01 bdero

This patch is still on my radar, will rewrite this against the updated HAL API when I find some time.

bdero avatar Mar 26 '24 23:03 bdero

Still on my radar

bdero avatar Jun 04 '24 23:06 bdero

Still on my radar, but closing to stop it from continuing to come up in the stale PR triage.

bdero avatar Aug 13 '24 23:08 bdero