engine icon indicating copy to clipboard operation
engine copied to clipboard

[draft github actions] Manual Actions to roll engine into framework

Open XilaiZhang opened this issue 2 years ago • 2 comments

Update 11/07: Added workarounds to fetch commit history. Sample pull request, sample workflow

Context: Synced with Casey and Kevin and did more researches on evaluating approaches to fetch green post submit builds. Updated design doc.

Approach This workflow takes engine_sha and release branch as inputs to run. To invoke this workflow, users run command from terminal, e.g. gh workflow run --repo flutter/engine -F engine_sha="123456" -F branch=flutter-3.16-candidate.0 manual.yml. example workflow and created Pull Request

TOKEN Needs installation of a PAT token to run.

Default ${{ github.token }} with permissions: write-all would fail with Error: Resource not accessible by integration. example workflow

Alternatives & Cons

  1. cron job approach : inefficient and hard to maintain
  2. skia auto roller : intrinsically cron job to scrape gcs bucket
  3. post submit check runs : not enough github api quota

Each alternative has its drawbacks, and is discussed in more details in design doc. For engine->flutter roll for now, we will skip the automation of getting green post submit engine builds, and let human handle this part.

XilaiZhang avatar Nov 07 '23 01:11 XilaiZhang

@godofredoc this was the pull request on flutter/engine with a minimal workflow. Would be great if I can get a review on it. Thank you!

XilaiZhang avatar Nov 15 '23 00:11 XilaiZhang

(triage) I spoke to @XilaiZhang and he tells me that this one is still on his radar.

goderbauer avatar Jan 23 '24 23:01 goderbauer