engine icon indicating copy to clipboard operation
engine copied to clipboard

Published 20 hours ago • verified publisher icon flutter

Web html emoji issule fix

Open zjrwdl opened this issue 1 year ago • 7 comments

Emoji display problem in flutter web html render #131337

before this pr: image

after this pr: image

List which issues are fixed by this PR. You must list at least one issue. https://github.com/flutter/flutter/issues/131337

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I signed the CLA.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

zjrwdl avatar Aug 02 '23 03:08 zjrwdl

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Aug 02 '23 03:08 flutter-dashboard[bot]

i did not modify any code related image

zjrwdl avatar Aug 02 '23 10:08 zjrwdl

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

flutter-dashboard[bot] avatar Aug 22 '23 10:08 flutter-dashboard[bot]

Hey, is this fix still planned? I'm also having issues with the html renderer with other ZWJ emojis

image

gildaswise avatar Oct 23 '23 23:10 gildaswise

https://github.com/flutter/engine/pull/44247#issuecomment-1661950687

Your PR affects text layout, and the failing tests are related to text layout. Please resolve the failing tests. Also, please add a new test which will fail before your change and which succeeds after your change.

harryterkelsen avatar Dec 05 '23 23:12 harryterkelsen

(triage) @zjrwdl Just checking in to see if you still have plans to address the feedback given above?

goderbauer avatar Feb 06 '24 23:02 goderbauer

(triage) @zjrwdl Do you still have plans to come back and address the feedback given above? Thank you.

goderbauer avatar May 28 '24 22:05 goderbauer

I am going to close this one since there was no follow-up. Feel free to reopen if you find the time to work on this again. Thank you.

goderbauer avatar Aug 06 '24 22:08 goderbauer