engine icon indicating copy to clipboard operation
engine copied to clipboard

Scribble method namespace

Open justinmc opened this issue 1 year ago • 2 comments

In the framework (https://github.com/flutter/flutter/pull/104128), the scribble feature is being moved out of TextInputClient and into its own class. This PR updates the naming of the platform channel methods to match their new names in the framework.

justinmc avatar Oct 06 '22 17:10 justinmc

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Oct 06 '22 17:10 flutter-dashboard[bot]

Depends on https://github.com/flutter/flutter/pull/104128

chinmaygarde avatar Oct 06 '22 20:10 chinmaygarde

@cyanglaz Good idea about doing this in stages. I've added back the TextInputClient usages so this PR now has both. I'll come back and remove them after this and the framework PR land.

justinmc avatar Oct 21 '22 23:10 justinmc