engine icon indicating copy to clipboard operation
engine copied to clipboard

Wasm harness for unit tests.

Open eyebrowsoffire opened this issue 2 years ago • 1 comments

This adds some preliminary support for compiling our unit tests to WebAssembly and running them. This doesn't actually work yet for two reasons: first, the version of Chrome we use for unit tests is 105.0, but many of the features used by dart2wasm are only available in Chrome 107, which is currently in dev (not stable). Secondly, there are still a number of issues with the compiler itself and the JS interop machinery, and the test harness simply fails at runtime right now.

Hence, compiling unit tests to wasm actually does work with this patch, but running them does not, at least for the time being. That being said, these are all hidden behind a flag, so our normal testing and build paths are not affected, so I think we can merge this in without affecting anything. Further changes down the line can be made to this as needed as we upgrade to newer versions of Chromium and bugs get fixed in the Dart SDK.

eyebrowsoffire avatar Sep 19 '22 17:09 eyebrowsoffire

Gold has detected about 1 new digest(s) on patchset 15. View them at https://flutter-engine-gold.skia.org/cl/github/36255

skia-gold avatar Sep 23 '22 21:09 skia-gold

Gold has detected about 34 new digest(s) on patchset 19. View them at https://flutter-engine-gold.skia.org/cl/github/36255

skia-gold avatar Oct 14 '22 00:10 skia-gold

Gold has detected about 4 new digest(s) on patchset 19. View them at https://flutter-engine-gold.skia.org/cl/github/36255

skia-gold avatar Oct 14 '22 00:10 skia-gold

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #36255 at sha 07db831c6d24118c54ec5683b77e08e5974c7b23

flutter-dashboard[bot] avatar Oct 14 '22 00:10 flutter-dashboard[bot]

@jakemac53 , I know you can't give a thorough review, I'm sending this to your desk mostly as FYI.

joshualitt avatar Oct 27 '22 22:10 joshualitt

Gold has detected about 1 new digest(s) on patchset 27. View them at https://flutter-engine-gold.skia.org/cl/github/36255

skia-gold avatar Oct 27 '22 23:10 skia-gold

Gold has detected about 1 new digest(s) on patchset 28. View them at https://flutter-engine-gold.skia.org/cl/github/36255

skia-gold avatar Oct 28 '22 01:10 skia-gold

Gold has detected about 1 new digest(s) on patchset 31. View them at https://flutter-engine-gold.skia.org/cl/github/36255

skia-gold avatar Nov 01 '22 19:11 skia-gold