flutter
[gn + codesign] mac code sign configuration for FlutterMacOS.framework.zip
context: this is related to recent change at https://github.com/flutter/engine/pull/35673/files , where the FlutterMacOS.framework.zip is now built through the global generator scripts.
This commit embed code signing configurations in the global generator script for FlutterMacOS.framework.zip.
Yeah I will convert this to a draft for now, and come back when https://github.com/flutter/engine/pull/35673 is ready
@XilaiZhang Is this still on your radar? Looks like https://github.com/flutter/engine/pull/35673 has landed.
rebuilt all the sub-builds and verified that the metadata files still work as expected for global generators. reopening this pull requests. However, across multiple builds it seems like all the symlinks in FlutterMacOS.framework are still dropped. I think this is a known issue and @godofredoc might be the expert to provide insights on the symlink drops. Thank you!
Is there an issue filed for preserving symlinks in frameworks that are archived? In the meantime, marking this as WIP.
Is there an issue filed for preserving symlinks in frameworks that are archived? In the meantime, marking this as WIP.
I don't think there are checks in the engine, but the last time this was an issue I wrote tests in the framework to validate the expected framework bundle structure after it's unzipped: https://github.com/flutter/flutter/blob/c5ceff11dd5226c3daaea867ed0c60ce4245d67a/packages/flutter_tools/test/host_cross_arch.shard/macos_content_validation_test.dart#L136
Is there an issue filed for preserving symlinks in frameworks that are archived? In the meantime, marking this as WIP.
sorry just to clarify, the engine artifacts in production have the correct symlink. It was just that when I build and test the artifact locally through gn the symlinks aren't there (probably because the symlinks are added through recipe). yeah for local build and test the issue is being discussed in https://github.com/flutter/flutter/issues/107674. Thanks for triaging!
Reverting because this change broke some lints: https://ci.chromium.org/p/flutter/builders/prod/Linux%20Android%20clang-tidy/2079
Reverting because this change broke some lints: https://ci.chromium.org/p/flutter/builders/prod/Linux%20Android%20clang-tidy/2079
Hm, why didn't Linux Android clang-tidy run in presubmit checks https://github.com/flutter/engine/pull/35707/checks? I think it should have since this change included a python file:
https://github.com/flutter/engine/blob/3aa112c75ccba5a6064f45243e6cd84ddf220357/.ci.yaml#L254
Hm, why didn't
Linux Android clang-tidyrun in presubmit checks
Filed https://github.com/flutter/flutter/issues/121160