engine icon indicating copy to clipboard operation
engine copied to clipboard

Adds artifacts to mac_ios release.

Open godofredoc opened this issue 3 years ago • 2 comments

This change generates and uploads the framework sdk and dsym files for mac_ios_release.

Bug: https://github.com/flutter/flutter/issues/81855

Pre-launch Checklist

  • [X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [X] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [X] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • [X] I listed at least one issue that this PR fixes in the description above.
  • [X] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • [X] I updated/added relevant documentation (doc comments with ///).
  • [X] I signed the CLA.
  • [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

godofredoc avatar Aug 12 '22 02:08 godofredoc

shall we merge this one in case it get forgotten?

XilaiZhang avatar Aug 12 '22 23:08 XilaiZhang

shall we merge this one in case it get forgotten?

We need to land another change to engine first.

godofredoc avatar Aug 12 '22 23:08 godofredoc