engine icon indicating copy to clipboard operation
engine copied to clipboard

Revert special character escaping

Open jonahwilliams opened this issue 3 years ago • 0 comments

I attempted to escape certain special characters in impeller to avoid invalid depfiles. While this no longer causes an invalid depfile error, unfortunately we now always recompile these files as the ninja expected escaping doesn't work as expected. Some alternatives I tried:

single escape: / - rebuilds double escape: // - invalid triple escape: /// rebuilds percent escape: %% invalid

To add insult to injury, the orginal depfile isn't invalid on windows, only on macOS/linux

Ultimately this was all just a workaround to test URI encoding, but we could also just test that in the framework. I think we should revert this handling here and add integration tests to the framework repo instead.

Fixes https://github.com/flutter/flutter/issues/109257

jonahwilliams avatar Aug 12 '22 01:08 jonahwilliams