engine icon indicating copy to clipboard operation
engine copied to clipboard

[embedder][fuchsia] Add paint regions to the FlutterLayer struct

Open abrush21 opened this issue 3 years ago • 2 comments

This change adds an array of FlutterRects to the FlutterLayer struct in the embedder API. These rects represent the regions within the layer that contain painted content. The fuchsia embedding will report this information to the platform compositor, to ensure that the hit test behavior for a particular layer is consistent with its visual geometry.

fxbug.dev/106560

Pre-launch Checklist

  • [X] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [X] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [X] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • [X] I listed at least one issue that this PR fixes in the description above.
  • [X] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • [X] I updated/added relevant documentation (doc comments with ///).
  • [X] I signed the CLA.
  • [X] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

abrush21 avatar Aug 10 '22 22:08 abrush21

The API itself looks fine to me.

Is there anything missing from this change, or is it good to go as-is?

abrush21 avatar Aug 11 '22 15:08 abrush21

The implementation as well as the updates to the unit-test fixture along with unittests should go here?

chinmaygarde avatar Aug 18 '22 20:08 chinmaygarde

@abrush21 Is this still on your radar?

Hixie avatar Nov 09 '22 00:11 Hixie