engine
engine copied to clipboard
flutter
Fix HTML renderer does not render border
Description
This PRs fixes an issue where the HTML renderer was not able to draw straight lines when stroke width is zero (For more information see the demo here: https://github.com/flutter/flutter/issues/46339#issuecomment-1188719650). The implementation choice is to draw a filled rectangle with a 1 width or a 1 height. This choice is done for optimization purposes (compared to relying on drawing the line on an Web canvas).
Related Issue
Fixes https://github.com/flutter/flutter/issues/46339
Tests
Adds 1 test.
Gold has detected about 1 new digest(s) on patchset 1. View them at https://flutter-engine-gold.skia.org/cl/github/34812
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).
If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.
Changes reported for pull request #34812 at sha af46a445b813344c428be6922c6fb0230d2c2fe0
![flutter-dashboard[bot] avatar](https://avatars.githubusercontent.com/in/64368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.
Gold has detected about 1 new digest(s) on patchset 1. View them at https://flutter-engine-gold.skia.org/cl/github/34812
Golden file changes are available for triage from new commit, Click here to view.
Changes reported for pull request #34812 at sha d3e0b0ccbe20167db2df4c0b24df3dd2459c6f04
@yjbanov It's the first time I filed a PR with a golden file change and I don't have the access rights to validate the golden file. Can you do it or explain me what is the procedure?
Yeah, I did it, but it's having trouble registering it. I just triaged it again. 🤞 this is pass now.
