engine
engine copied to clipboard
flutter
Web layout detection
Part of https://github.com/flutter/flutter/issues/100456
Pre-launch Checklist
- [ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
- [ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
- [ ] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
- [ ] I listed at least one issue that this PR fixes in the description above.
- [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
- [ ] I updated/added relevant documentation (doc comments with
///). - [ ] I signed the CLA.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
Gold has detected about 1 new digest(s) on patchset 20. View them at https://flutter-engine-gold.skia.org/cl/github/34625
Gold has detected about 1 new digest(s) on patchset 65. View them at https://flutter-engine-gold.skia.org/cl/github/34625
@mdebbar I've sync'd the PR with the latest master, addressing as many of you comments as possible.
I've also made a non-trivial change that compresses the data, which reduces the package size overhead of this PR further (see PR body).
I'm still resolving some CI issues. In the mean time, can you take another look?
@gspencergoog I've addressed all your comments. I'd like to add another test for the en-in case, but I'm currently having a problem with felt test. Nevertheless, can you take another look?
@mdebbar I've applied the fix to BUILD.gn as you said. Those changes are indeed not necessary.
Gold has detected about 1 new digest(s) on patchset 91. View them at https://flutter-engine-gold.skia.org/cl/github/34625